Skip to content

Glasgow | 26-ITP-Jan | Mohsen Gharaei | Sprint 1 | Wireframe #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Mohsen-tech12 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Glasgow | 26-ITP-Jan | Mohsen Gharaei | Sprint 1 | Wireframe #1098

Mohsen-tech12 wants to merge 2 commits into from
+43 −14

Conversation

@Mohsen-tech12
Copy link

@Mohsen-tech12 Mohsen-tech12 commented Jan 30, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have changed the HTML and CSS code to make a web page and explain some web development fundamentals.

Questions

@netlify
Copy link

netlify bot commented Jan 30, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit f3bf32b
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/697cd67b0bfbf6000806a59b
😎 Deploy Preview https://deploy-preview-1098--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@Mohsen-tech12 Mohsen-tech12 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
@Mohsen-tech12 Mohsen-tech12 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
@github-actions

This comment has been minimized.

Sign in to view
@Mohsen-tech12 Mohsen-tech12 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
@Mohsen-tech12 Mohsen-tech12 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Feb 4, 2026
LonMcGregor
LonMcGregor reviewed Feb 4, 2026
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this task, please review my comments to try to improve further

Wireframe/index.html

</body>
</html>
<!DOCTYPE html>
Copy link

@LonMcGregor LonMcGregor Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this block of html at the bottom doing?

Wireframe/index.html
<a href="https://www.experienceux.co.uk/faqs/what-is-wireframing/">Read more</a>
</article> <!-- article 2 -->

<article> <!-- article 3 -->
Copy link

@LonMcGregor LonMcGregor Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compare the two bottom articles. Do their layouts look symmetrical?

Wireframe/index.html
This is the default, provided code and no changes have been made yet.
</p>
</footer>
</footer>
Copy link

@LonMcGregor LonMcGregor Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add something to the footer so we can test that it works?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mohsen-tech12 @LonMcGregor